Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: java FFI things #2644

Merged
merged 4 commits into from
Mar 11, 2025
Merged

fix: java FFI things #2644

merged 4 commits into from
Mar 11, 2025

Conversation

a10y
Copy link
Contributor

@a10y a10y commented Mar 10, 2025

Implement some small fixes for Java

  • Handle dropping field DTypes when creating Struct DType, less error-prone than relying on user to call free
  • Expose nullability over FFI and in Java bindings

OLD DESCRIPTION:

Fixing some small things, blocked on a ticket with Sonatype Centrla to get our Central account migrated to the old OSSRH account type (they don't have support for automated gradle publishing to the new repo, just the old repo).

@robert3005
Copy link
Member

maven central is such a wonderful place...

@a10y
Copy link
Contributor Author

a10y commented Mar 10, 2025

They seem pretty fixated on not allowing any more OSSRH accounts and forcing everyone into their new Central Portal system. Which, conveniently, does not have a supported Gradle Plugin publish pathway...

@a10y a10y changed the title ci: java publishing fix: java FFI things Mar 10, 2025
@a10y a10y marked this pull request as ready for review March 10, 2025 21:59
@a10y
Copy link
Contributor Author

a10y commented Mar 10, 2025

I'm repurposing this PR to just be for the FFI fixes and gonna punt on publishing. I wasted about an hour today trying to get publishing working with jreleaser but kept running into problems

@a10y a10y merged commit 6b135ac into develop Mar 11, 2025
27 checks passed
@a10y a10y deleted the aduffy/java-publish branch March 11, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants